This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Repository navigation
[AOL] Enable ruleset, remove nonfunctional domains, slightly expand coverage - #11722
Merged
Merged
Conversation
Contributor
|
Does this close #4495? |
Contributor
Author
|
I have closed #4495. |
Contributor
|
Thanks! |
luciancor
pushed a commit
to luciancor/https-everywhere
that referenced
this pull request
Aug 24, 2017
…overage (EFForg#11722) * [AOL] Enable ruleset, remove nonfunctional domains, slightly expand coverage * [AOL] Remove advertising subdomain, secure certain cookies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this pull request, a number of problematical targets (and rules specifically related to those targets) have been removed from the ruleset. However, it is not clear as to how, and whether, these targets should be documented in the ruleset's comments about nonfunctional domains and problematic hosts. In particular, the difference between "nonfunctional" and "problematic" is not totally clear. In addition, if a domain does not work for both HTTP and HTTPS, should it be listed in the ruleset comments at all? (Or, are the ruleset comments about nonfunctional and problematic domains specifically intended for domains that work with HTTP but which have issues only with HTTPS?)
The behavior of the removed targets is as follows:
autos.aol.com- http://autos.aol.com/ generates a redirect to http://www.autoblog.com/, https://autos.aol.com/ generates an "Unable to connect" error.els-sso.corp.aol.com- http://els-sso.corp.aol.com/ and https://els-sso.corp.aol.com/ both generate a "Server not found" error.s.on.aol.com- http://s.on.aol.com/ generates a 503 response, https://s.on.aol.com/ generates a certificate expired error.t.on.aol.com- http://t.on.aol.com/ generates a 503 response, https://t.on.aol.com/ generates a certificate expired error.cdn.webmail.aol.com- http://cdn.webmail.aol.com/ and https://cdn.webmail.aol.com/ both generate a "Server not found" error.as.on.aol.com- http://as.on.aol.com/ and https://as.on.aol.com/ both generate a "Server not found" error.at.on.aol.com- http://at.on.aol.com/ and https://at.on.aol.com/ both generate a "Server not found" error.support.on.aol.com- http://support.on.aol.com/ generates a 503 response, https://support.on.aol.com/ generates a certificate expired error.At the current time,
autosis listed as a nonfunctional subdomain that redirects to HTTP. Thes.on,t.on, andsupport.onsubdomains are listed as nonfunctional domains that give a cert expired error. The subdomains that give a "Server not found" error for both HTTP and HTTPS are not listed at all.